Test path mapping in Bazel #18155
Closed
Test path mapping in Bazel #18155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
bazel-path-stripping
branch
from
174a0e0
to
2d0e761
Compare
fmeum
force-pushed
the
bazel-path-stripping
branch
from
2d0e761
to
9850659
Compare
fmeum
force-pushed
the
bazel-path-stripping
branch
2 times, most recently
from
533efc8
to
e45173b
Compare
fmeum
force-pushed
the
bazel-path-stripping
branch
2 times, most recently
from
98bd6c7
to
f38db1e
Compare
|
CC @aranguyen |
aranguyen
reviewed
Sep 21, 2023
src/main/java/com/google/devtools/build/lib/analysis/actions/CustomCommandLine.java
Outdated
Show resolved
Hide resolved
fmeum
force-pushed
the
bazel-path-stripping
branch
from
f38db1e
to
09d02eb
Compare
fmeum
force-pushed
the
bazel-path-stripping
branch
2 times, most recently
from
eedcd5f
to
d417ec5
Compare
This was referenced Oct 4, 2023
fmeum
force-pushed
the
bazel-path-stripping
branch
6 times, most recently
from
471cbc8
to
73ec1ad
Compare
|
@fmeum Do we need this for bazelcon? |
It's just the combination of all the other required PRs + end-to-end tests. When the required PRs have been merged, we will probably want to merge the tests, but don't have to before BazelCon :-) |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
`PathMapper`s rewrite paths in command lines to make them more cache friendly, which requires executor support to stage files at the rewritten paths. This commit wires up the `PathMapper` used by a given `Spawn` in `SpawnInputsExpander`, which takes care of this for inputs to `Spawn`s executed in a sandbox or remotely. Constructs specific to Blaze, filesets and archived tree artifacts, are not covered by this change. An end-to-end test will be added in #18155, but requires #19718, #19719, and #19721. Work towards #6526 Closes #19718. PiperOrigin-RevId: 571109361 Change-Id: Ia38464011f658178ab2a1981a3ddaf5aead7c8fa
fmeum
force-pushed
the
bazel-path-stripping
branch
from
73ec1ad
to
48af955
Compare
fmeum
requested review from
gregestren
and removed request for
a team and
lberki
|
@gregestren Could you review this while Ara is OOO? It essentially consists of tests only, with one very minor change described in the PR description. Getting this merged would allow me to more effectively work on #19872 and get it in shape, including tests, before Ara is back. |
fmeum
force-pushed
the
bazel-path-stripping
branch
from
d56a922
to
c52b670
Compare
|
Sure, I'll take a look today. |
gregestren
reviewed
Nov 8, 2023
src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java
Show resolved
Hide resolved
fmeum
force-pushed
the
bazel-path-stripping
branch
from
c52b670
to
406a2b7
Compare
gregestren
approved these changes
Nov 9, 2023
gregestren
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.0.0 |
bazel-io
removed
the
potential release blocker
gregestren
reviewed
Nov 13, 2023
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 13, 2023
Add end-to-end tests to verify that `--experimental_output_paths=strip` works with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enable `config_stripped_outputs_test` for Bazel (e.g. make it work on macOS). This requires a minor changes: We ensure that full `.jdeps` are rewritten to contain unmapped paths even after a fallback to full classpath. Closes bazelbuild#18155. PiperOrigin-RevId: 582014351 Change-Id: If9c51acb090d9fc4bc86052143ad9960e44fd8a7
keertk
pushed a commit
that referenced
this pull request
Nov 13, 2023
Add end-to-end tests to verify that `--experimental_output_paths=strip` works with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enable `config_stripped_outputs_test` for Bazel (e.g. make it work on macOS). This requires a minor changes: We ensure that full `.jdeps` are rewritten to contain unmapped paths even after a fallback to full classpath. Closes #18155. Commit cab7c6b PiperOrigin-RevId: 582014351 Change-Id: If9c51acb090d9fc4bc86052143ad9960e44fd8a7 Co-authored-by: Googler <gregce@google.com>
|
The changes in this PR have been included in Bazel 7.0.0 RC5. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add end-to-end tests to verify that
--experimental_output_paths=stripworks with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enableconfig_stripped_outputs_testfor Bazel (e.g. make it work on macOS).This requires a minor changes: We ensure that full
.jdepsare rewritten to contain unmapped paths even after a fallback to full classpath.